Re: [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init()

2018-10-01 Thread David Miller
From: Dan Carpenter Date: Sat, 22 Sep 2018 16:46:48 +0300 > If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we > return -EINVAL. But we don't check whether it's smaller than > sizeof(struct xt_entry_target) and that could lead to an out of bounds > read. > > Fixes: 7ba699c6

[PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init()

2018-09-22 Thread Dan Carpenter
If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we return -EINVAL. But we don't check whether it's smaller than sizeof(struct xt_entry_target) and that could lead to an out of bounds read. Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API")