Re: [PATCH net] net: reorder 'struct net' fields to avoid false sharing

2019-10-19 Thread David Miller
From: Eric Dumazet Date: Fri, 18 Oct 2019 15:20:05 -0700 > Intel test robot reported a ~7% regression on TCP_CRR tests > that they bisected to the cited commit. > > Indeed, every time a new TCP socket is created or deleted, > the atomic counter net->count is touched (via get_net(net) > and put_n

[PATCH net] net: reorder 'struct net' fields to avoid false sharing

2019-10-18 Thread Eric Dumazet
Intel test robot reported a ~7% regression on TCP_CRR tests that they bisected to the cited commit. Indeed, every time a new TCP socket is created or deleted, the atomic counter net->count is touched (via get_net(net) and put_net(net) calls) So cpus might have to reload a contended cache line in