Re: [PATCH net] net: phylink: Fix flow control for fixed-link

2019-07-27 Thread David Miller
From: René van Dorst Date: Sat, 27 Jul 2019 11:40:11 +0200 > In phylink_parse_fixedlink() the pl->link_config.advertising bits are AND > with pl->supported, pl->supported is zeroed and only the speed/duplex > modes and MII bits are set. > So pl->link_config.advertising always loses the flow contr

Re: [PATCH net] net: phylink: Fix flow control for fixed-link

2019-07-27 Thread Russell King - ARM Linux admin
On Sat, Jul 27, 2019 at 11:40:11AM +0200, René van Dorst wrote: > In phylink_parse_fixedlink() the pl->link_config.advertising bits are AND > with pl->supported, pl->supported is zeroed and only the speed/duplex > modes and MII bits are set. > So pl->link_config.advertising always loses the flow co

[PATCH net] net: phylink: Fix flow control for fixed-link

2019-07-27 Thread René van Dorst
In phylink_parse_fixedlink() the pl->link_config.advertising bits are AND with pl->supported, pl->supported is zeroed and only the speed/duplex modes and MII bits are set. So pl->link_config.advertising always loses the flow control/pause bits. By setting Pause and Asym_Pause bits in pl->supported