Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Sun, 24 Feb 2019 18:01:18 +0100 > With the switch to phy_resolve_aneg_linkmode() we don't read from the > chip any longer what is advertised but use phydev->advertising directly. > For a fixed phy however this bitmap is empty so far, what results in > no common mode be

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 18:57, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: >> With the switch to phy_resolve_aneg_linkmode() we don't read from the >> chip any longer what is advertised but use phydev->advertising directly. >> For a fixed phy however this bitmap is e

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: > With the switch to phy_resolve_aneg_linkmode() we don't read from the > chip any longer what is advertised but use phydev->advertising directly. > For a fixed phy however this bitmap is empty so far, what results in > no common mode

[PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
With the switch to phy_resolve_aneg_linkmode() we don't read from the chip any longer what is advertised but use phydev->advertising directly. For a fixed phy however this bitmap is empty so far, what results in no common mode being found. This breaks DSA. Fix this by advertising everything that is