Re: [PATCH net] net: phy: fix phy_validate_pause

2019-05-05 Thread David Miller
From: Heiner Kallweit Date: Wed, 1 May 2019 21:54:28 +0200 > We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't > need to be supported. Therefore extend the first check to check > for rx_pause being set. > > See also phy_set_asym_pause: > rx=0 and tx=1: advertise asym pause only >

[PATCH net] net: phy: fix phy_validate_pause

2019-05-01 Thread Heiner Kallweit
We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't need to be supported. Therefore extend the first check to check for rx_pause being set. See also phy_set_asym_pause: rx=0 and tx=1: advertise asym pause only rx=0 and tx=0: stop advertising both pause modes The fixed commit isn't w