Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-25 Thread David Miller
From: Heiner Kallweit Date: Tue, 25 Dec 2018 09:30:45 +0100 > On 24.12.2018 23:23, David Miller wrote: >> From: Heiner Kallweit >> Date: Sun, 23 Dec 2018 15:00:26 +0100 >> >>> Currently we return immediately if callback config_init isn't defined. >>> This prevents the fixups from being executed

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-25 Thread Heiner Kallweit
On 24.12.2018 23:23, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 23 Dec 2018 15:00:26 +0100 > >> Currently we return immediately if callback config_init isn't defined. >> This prevents the fixups from being executed. I see no dependency >> between fixups and config_init, therefore ch

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-24 Thread David Miller
From: Heiner Kallweit Date: Sun, 23 Dec 2018 15:00:26 +0100 > Currently we return immediately if callback config_init isn't defined. > This prevents the fixups from being executed. I see no dependency > between fixups and config_init, therefore change the function to > run the fixups also if conf

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-23 Thread Heiner Kallweit
On 23.12.2018 18:28, Andrew Lunn wrote: > On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote: >> On 23.12.2018 18:07, Andrew Lunn wrote: >>> On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote: Currently we return immediately if callback config_init isn't defined.

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-23 Thread Andrew Lunn
On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote: > On 23.12.2018 18:07, Andrew Lunn wrote: > > On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote: > >> Currently we return immediately if callback config_init isn't defined. > >> This prevents the fixups from being execut

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-23 Thread Heiner Kallweit
On 23.12.2018 18:07, Andrew Lunn wrote: > On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote: >> Currently we return immediately if callback config_init isn't defined. >> This prevents the fixups from being executed. I see no dependency >> between fixups and config_init, therefore chan

Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-23 Thread Andrew Lunn
On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote: > Currently we return immediately if callback config_init isn't defined. > This prevents the fixups from being executed. I see no dependency > between fixups and config_init, therefore change the function to > run the fixups also if c

[PATCH net] net: phy: fix phy_init_hw fixup handling

2018-12-23 Thread Heiner Kallweit
Currently we return immediately if callback config_init isn't defined. This prevents the fixups from being executed. I see no dependency between fixups and config_init, therefore change the function to run the fixups also if config_init isn't defined. Fixes: 2f5cb43406d0 ("phylib: Properly reiniti