Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread David Miller
From: Heiner Kallweit Date: Tue, 3 Jul 2018 22:34:54 +0200 > Currently also the pause flags are removed from phydev->supported because > they're not included in PHY_DEFAULT_FEATURES. I don't think this is > intended, especially when considering that this function can be called > via phy_set_max_s

Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread Florian Fainelli
On July 3, 2018 10:34:54 PM GMT+02:00, Heiner Kallweit wrote: >Currently also the pause flags are removed from phydev->supported >because >they're not included in PHY_DEFAULT_FEATURES. I don't think this is >intended, especially when considering that this function can be called >via phy_set_max_s

Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread Andrew Lunn
On Tue, Jul 03, 2018 at 10:34:54PM +0200, Heiner Kallweit wrote: > Currently also the pause flags are removed from phydev->supported because > they're not included in PHY_DEFAULT_FEATURES. I don't think this is > intended, especially when considering that this function can be called > via phy_set_m

[PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-03 Thread Heiner Kallweit
Currently also the pause flags are removed from phydev->supported because they're not included in PHY_DEFAULT_FEATURES. I don't think this is intended, especially when considering that this function can be called via phy_set_max_speed() anywhere in a driver. Change the masking to mask out only the