Re: [PATCH net] net: phy: fix WoL handling when suspending the PHY

2018-09-22 Thread Heiner Kallweit
On 22.09.2018 18:44, Andrew Lunn wrote: > On Sat, Sep 22, 2018 at 01:32:55AM +0200, Heiner Kallweit wrote: >> Actually there's nothing wrong with the two changes, they just >> revealed a problem which has been existing before. > > Hi Heiner > > This is missing a bit of context. Which two changes?

Re: [PATCH net] net: phy: fix WoL handling when suspending the PHY

2018-09-22 Thread Andrew Lunn
On Sat, Sep 22, 2018 at 01:32:55AM +0200, Heiner Kallweit wrote: > Actually there's nothing wrong with the two changes, they just > revealed a problem which has been existing before. Hi Heiner This is missing a bit of context. Which two changes? I assume you mean the two Fixes: > > Core of the

[PATCH net] net: phy: fix WoL handling when suspending the PHY

2018-09-21 Thread Heiner Kallweit
Actually there's nothing wrong with the two changes, they just revealed a problem which has been existing before. Core of the problem is that phy_suspend() suspends the PHY when it should not because of WoL. phy_suspend() checks for WoL already, but this works only if the PHY driver handles WoL (w