Re: [PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

2019-03-25 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Mar 2019 20:00:20 +0100 > So far we effectively clear the BMCR register. Some PHY's can deal > with this (e.g. because they reset BMCR to a default as part of a > soft-reset) whilst on others this causes issues because e.g. the > autoneg bit is cleared. Marvell

Re: [PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

2019-03-23 Thread Florian Fainelli
On 3/22/2019 12:00 PM, Heiner Kallweit wrote: > So far we effectively clear the BMCR register. Some PHY's can deal > with this (e.g. because they reset BMCR to a default as part of a > soft-reset) whilst on others this causes issues because e.g. the > autoneg bit is cleared. Marvell is an exampl

[PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

2019-03-22 Thread Heiner Kallweit
So far we effectively clear the BMCR register. Some PHY's can deal with this (e.g. because they reset BMCR to a default as part of a soft-reset) whilst on others this causes issues because e.g. the autoneg bit is cleared. Marvell is an example, see also thread [0]. So let's be a little bit more gen