Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY

2020-05-15 Thread Kevin Lo
On Fri, May 15, 2020 at 08:53:37AM -0700, Florian Fainelli wrote: > > > > On 5/14/2020 10:22 PM, Kevin Lo wrote: > > The BCM54811 PHY shares many similarities with the already supported > > BCM54810 > > PHY but additionally requires some semi-unique configuration. > > This looks mostly fine, j

Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY

2020-05-15 Thread Florian Fainelli
On 5/14/2020 10:22 PM, Kevin Lo wrote: > The BCM54811 PHY shares many similarities with the already supported BCM54810 > PHY but additionally requires some semi-unique configuration. This looks mostly fine, just a couple of nits: - the patch should be submitted against net-next, since it is a

[PATCH net] net: phy: broadcom: add support for BCM54811 PHY

2020-05-15 Thread Kevin Lo
The BCM54811 PHY shares many similarities with the already supported BCM54810 PHY but additionally requires some semi-unique configuration. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index d14d91b759b7..0360a5cfdb9e 100644 --- a/drivers/net/ph