Re: [PATCH net] net: mptcp: make DACK4/DACK8 usage consistent among all subflows

2020-10-09 Thread Jakub Kicinski
On Tue, 6 Oct 2020 18:26:17 +0200 Davide Caratti wrote: > using packetdrill it's possible to observe the same MPTCP DSN being acked > by different subflows with DACK4 and DACK8. This is in contrast with what > specified in RFC8684 §3.3.2: if an MPTCP endpoint transmits a 64-bit wide > DSN, it MUST

Re: [PATCH net] net: mptcp: make DACK4/DACK8 usage consistent among all subflows

2020-10-06 Thread Mat Martineau
On Tue, 6 Oct 2020, Davide Caratti wrote: using packetdrill it's possible to observe the same MPTCP DSN being acked by different subflows with DACK4 and DACK8. This is in contrast with what specified in RFC8684 §3.3.2: if an MPTCP endpoint transmits a 64-bit wide DSN, it MUST be acknowledged wit

[PATCH net] net: mptcp: make DACK4/DACK8 usage consistent among all subflows

2020-10-06 Thread Davide Caratti
using packetdrill it's possible to observe the same MPTCP DSN being acked by different subflows with DACK4 and DACK8. This is in contrast with what specified in RFC8684 §3.3.2: if an MPTCP endpoint transmits a 64-bit wide DSN, it MUST be acknowledged with a 64-bit wide DACK. Fix 'use_64bit_ack' var