Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread David Miller
From: "Christian Benvenuti (benve)" Date: Tue, 11 Jun 2019 00:35:59 + > if we assume that the kernel is supposed to deal properly with .1p tagged > frames, regardless > of what the next header is (802.{1Q,1AD} or something else), I think the case > this patch was > trying to address (that

RE: [PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread Christian Benvenuti (benve)
> -Original Message- > From: Stephen Suryaputra > Sent: Monday, June 10, 2019 4:09 PM > To: David Miller > Cc: Govindarajulu Varadarajan (gvaradar) ; Christian > Benvenuti (benve) ; netdev@vger.kernel.org; > govind.vara...@gmail.com > Subject: Re: [PATCH net] n

Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread Govindarajulu Varadarajan (gvaradar)
On Mon, 2019-06-10 at 14:28 -0700, David Miller wrote: > From: Govindarajulu Varadarajan > Date: Mon, 10 Jun 2019 07:27:02 -0700 > > > When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4], > > vlan_do_receive() returns false if it does not find vlan_dev. Later > > __netif_receive_skb_

Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread Stephen Suryaputra
On Mon, Jun 10, 2019 at 02:28:10PM -0700, David Miller wrote: > From: Govindarajulu Varadarajan > Date: Mon, 10 Jun 2019 07:27:02 -0700 > > > When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4], > > vlan_do_receive() returns false if it does not find vlan_dev. Later > > __netif_recei

[PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread Govindarajulu Varadarajan
When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4], vlan_do_receive() returns false if it does not find vlan_dev. Later __netif_receive_skb_core() fails to find packet type handler for skb->protocol 801.1AD and drops the packet. 801.1P header with vlan id 0 should be handled as untag

Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

2019-06-10 Thread David Miller
From: Govindarajulu Varadarajan Date: Mon, 10 Jun 2019 07:27:02 -0700 > When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4], > vlan_do_receive() returns false if it does not find vlan_dev. Later > __netif_receive_skb_core() fails to find packet type handler for > skb->protocol 801.1A