Re: [PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-13 Thread Yonghong Song
On 10/12/20 11:56 PM, Vasily Averin wrote: Dear Yonghong Song, thank you for reporting the problem. As far as I understand the problem here is that pos is incremented in .start function. Yes. I do not,like an idea to avoid increment in ipv6_route_seq_next() however ipv6_route_seq_start c

Re: [PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-12 Thread Vasily Averin
Dear Yonghong Song, thank you for reporting the problem. As far as I understand the problem here is that pos is incremented in .start function. I do not,like an idea to avoid increment in ipv6_route_seq_next() however ipv6_route_seq_start can provide fake argument instead. --- a/net/ipv6/ip6_fi

[PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-12 Thread Yonghong Song
Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug https://bugzilla.kernel.org/show_bug.cgi?id=206283 The commit effectively does: - increase pos for al