Re: [PATCH net] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse()

2019-09-27 Thread David Miller
From: Dan Carpenter Date: Wed, 25 Sep 2019 14:05:54 +0300 > The "gmac->phy_mode" variable is an enum and in this context GCC will > treat it as an unsigned int so the error handling will never be > triggered. > > Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer") > Signed-off-by: Dan Carpent

[PATCH net] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse()

2019-09-25 Thread Dan Carpenter
The "gmac->phy_mode" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling will never be triggered. Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- 1 f