Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread David Miller
From: Alexander Lobakin Date: Fri, 5 Jun 2020 15:53:24 +0300 > Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") > added headroom alignment check against 8. > Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not > aligned to cacheline size), it actually

[PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread Alexander Lobakin
Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") added headroom alignment check against 8. Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not aligned to cacheline size), it actually aligns headroom down, while skb/xdp_buff headroom should be *at least*