Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-11-28 Thread Tobias Waldekranz
On Sat, Nov 28, 2020 at 00:27, Vladimir Oltean wrote: > On Sat, Nov 28, 2020 at 12:58:10AM +0100, Tobias Waldekranz wrote: >> That sounds like a good idea. We have run into another issue with the >> MDB that maybe could be worked into this changeset. This is what we have >> observed on 4.19, but f

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-11-27 Thread Vladimir Oltean
On Sat, Nov 28, 2020 at 12:58:10AM +0100, Tobias Waldekranz wrote: > That sounds like a good idea. We have run into another issue with the > MDB that maybe could be worked into this changeset. This is what we have > observed on 4.19, but from looking at the source it does not look like > anything h

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-11-27 Thread Tobias Waldekranz
On Fri, Oct 16, 2020 at 00:27, Vladimir Oltean wrote: > Currently any DSA switch that implements the multicast ops (properly, > that is) gets these errors after just sitting for a while, with at least > 2 ports bridged: > > [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-11-27 Thread Vladimir Oltean
Hi Florian, On Mon, Oct 19, 2020 at 07:11:47PM -0700, Florian Fainelli wrote: > On 10/15/2020 2:27 PM, Vladimir Oltean wrote: > > Currently any DSA switch that implements the multicast ops (properly, > > that is) gets these errors after just sitting for a while, with at least > > 2 ports bridged:

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Florian Fainelli
On 10/15/2020 2:27 PM, Vladimir Oltean wrote: Currently any DSA switch that implements the multicast ops (properly, that is) gets these errors after just sitting for a while, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Vladimir Oltean
On Tue, Oct 20, 2020 at 02:06:32AM +0200, Andrew Lunn wrote: > I agree with the analysis. This is how i designed it! [...] > So i decided to keep it KISS and not bother with reference counting. Well, I can't argue with that then... > The other part of the argument is that DSA is stateless, in tha

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Jakub Kicinski
On Tue, 20 Oct 2020 02:07:46 +0200 Andrew Lunn wrote: > On Mon, Oct 19, 2020 at 04:55:14PM -0700, Jakub Kicinski wrote: > > On Fri, 16 Oct 2020 00:27:11 +0300 Vladimir Oltean wrote: > > > Currently any DSA switch that implements the multicast ops (properly, > > > that is) gets these errors after

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Andrew Lunn
On Mon, Oct 19, 2020 at 04:55:14PM -0700, Jakub Kicinski wrote: > On Fri, 16 Oct 2020 00:27:11 +0300 Vladimir Oltean wrote: > > Currently any DSA switch that implements the multicast ops (properly, > > that is) gets these errors after just sitting for a while, with at least > > 2 ports bridged: > >

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Andrew Lunn
On Fri, Oct 16, 2020 at 12:27:11AM +0300, Vladimir Oltean wrote: > Currently any DSA switch that implements the multicast ops (properly, > that is) gets these errors after just sitting for a while, with at least > 2 ports bridged: > > [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to

Re: [PATCH net] net: dsa: reference count the host mdb addresses

2020-10-19 Thread Jakub Kicinski
On Fri, 16 Oct 2020 00:27:11 +0300 Vladimir Oltean wrote: > Currently any DSA switch that implements the multicast ops (properly, > that is) gets these errors after just sitting for a while, with at least > 2 ports bridged: > > [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del ob

[PATCH net] net: dsa: reference count the host mdb addresses

2020-10-15 Thread Vladimir Oltean
Currently any DSA switch that implements the multicast ops (properly, that is) gets these errors after just sitting for a while, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The reason has to do with this piece of code: