Re: [PATCH net] net: dsa: Properly propagate errors from dsa_switch_setup_one

2015-05-31 Thread David Miller
From: Florian Fainelli Date: Fri, 29 May 2015 10:29:46 -0700 > While shuffling some code around, dsa_switch_setup_one() was introduced, > and it was modified to return either an error code using ERR_PTR() or a > NULL pointer when running out of memory or failing to setup a switch. > > This is a

Re: [PATCH net] net: dsa: Properly propagate errors from dsa_switch_setup_one

2015-05-29 Thread Andrew Lunn
On Fri, May 29, 2015 at 10:29:46AM -0700, Florian Fainelli wrote: > While shuffling some code around, dsa_switch_setup_one() was introduced, > and it was modified to return either an error code using ERR_PTR() or a > NULL pointer when running out of memory or failing to setup a switch. > > This is

[PATCH net] net: dsa: Properly propagate errors from dsa_switch_setup_one

2015-05-29 Thread Florian Fainelli
While shuffling some code around, dsa_switch_setup_one() was introduced, and it was modified to return either an error code using ERR_PTR() or a NULL pointer when running out of memory or failing to setup a switch. This is a problem for its caler: dsa_switch_setup() which uses IS_ERR() and expects