Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

2019-02-06 Thread David Miller
From: Dan Carpenter Date: Wed, 6 Feb 2019 18:35:15 +0300 > This function can't succeed if dp->pl is NULL. It will Oops inside the > call to return phylink_ethtool_get_eee(dp->pl, e); > > Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") > Signed-off-by: Dan Carpenter Applied

Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

2019-02-06 Thread Vivien Didelot
On Wed, 6 Feb 2019 18:35:15 +0300, Dan Carpenter wrote: > This function can't succeed if dp->pl is NULL. It will Oops inside the > call to return phylink_ethtool_get_eee(dp->pl, e); > > Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") > Signed-off-by: Dan Carpenter Reviewed

Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

2019-02-06 Thread Florian Fainelli
On 2/6/19 7:35 AM, Dan Carpenter wrote: > This function can't succeed if dp->pl is NULL. It will Oops inside the > call to return phylink_ethtool_get_eee(dp->pl, e); > > Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") > Signed-off-by: Dan Carpenter Reviewed-by: Florian Faine

[PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

2019-02-06 Thread Dan Carpenter
This function can't succeed if dp->pl is NULL. It will Oops inside the call to return phylink_ethtool_get_eee(dp->pl, e); Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") Signed-off-by: Dan Carpenter --- net/dsa/slave.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-