Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-10-17 Thread Eric Dumazet
On Sat, 2015-10-17 at 05:02 -0700, David Miller wrote: > Sorry I've been meaning to go back and apply it properly. I'll do that right > now... > > There, done and properly queued up for -stable too. :) > Perfect, thanks a lot David. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-10-17 Thread David Miller
From: Eric Dumazet Date: Fri, 16 Oct 2015 08:38:38 -0700 > On Tue, 2015-09-29 at 21:56 -0700, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 29 Sep 2015 18:52:25 -0700 >> >> > From: Eric Dumazet >> > >> > Greg reported crashes hitting the following check in __sk_backlog_rcv() >> > >

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-10-16 Thread Eric Dumazet
On Tue, 2015-09-29 at 21:56 -0700, David Miller wrote: > From: Eric Dumazet > Date: Tue, 29 Sep 2015 18:52:25 -0700 > > > From: Eric Dumazet > > > > Greg reported crashes hitting the following check in __sk_backlog_rcv() > > > > BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); > > > > The pfmemall

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-10-02 Thread Eric Dumazet
On Tue, 2015-09-29 at 21:56 -0700, David Miller wrote: > From: Eric Dumazet > Date: Tue, 29 Sep 2015 18:52:25 -0700 > > > From: Eric Dumazet > > > > Greg reported crashes hitting the following check in __sk_backlog_rcv() > > > > BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); > > > > The pfmemall

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-09-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Sep 2015 18:52:25 -0700 > From: Eric Dumazet > > Greg reported crashes hitting the following check in __sk_backlog_rcv() > > BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); > > The pfmemalloc bit is currently checked in sk_filter(). > > This works correctly for

[PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-09-29 Thread Eric Dumazet
From: Eric Dumazet Greg reported crashes hitting the following check in __sk_backlog_rcv() BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); The pfmemalloc bit is currently checked in sk_filter(). This works correctly for TCP, because sk_filter() is ran in tcp_v[46]_rcv() before hitting the preq