Re: [PATCH net] net: Do not clear the socket TX queue in sock_orphan()

2020-06-22 Thread Tariq Toukan
On 6/22/2020 7:56 PM, Eric Dumazet wrote: On 6/22/20 9:24 AM, Tariq Toukan wrote: On 6/22/2020 6:53 PM, Eric Dumazet wrote: On 6/21/20 7:09 AM, Tariq Toukan wrote: sock_orphan() call to sk_set_socket() implies clearing the sock TX queue. This might cause unexpected out-of-order transm

Re: [PATCH net] net: Do not clear the socket TX queue in sock_orphan()

2020-06-22 Thread Eric Dumazet
On 6/22/20 9:24 AM, Tariq Toukan wrote: > > > On 6/22/2020 6:53 PM, Eric Dumazet wrote: >> >> >> On 6/21/20 7:09 AM, Tariq Toukan wrote: >>> sock_orphan() call to sk_set_socket() implies clearing the sock TX queue. >>> This might cause unexpected out-of-order transmit, as outstanding packets >

Re: [PATCH net] net: Do not clear the socket TX queue in sock_orphan()

2020-06-22 Thread Tariq Toukan
On 6/22/2020 6:53 PM, Eric Dumazet wrote: On 6/21/20 7:09 AM, Tariq Toukan wrote: sock_orphan() call to sk_set_socket() implies clearing the sock TX queue. This might cause unexpected out-of-order transmit, as outstanding packets can pick a different TX queue and bypass the ones already que

Re: [PATCH net] net: Do not clear the socket TX queue in sock_orphan()

2020-06-22 Thread Eric Dumazet
On 6/21/20 7:09 AM, Tariq Toukan wrote: > sock_orphan() call to sk_set_socket() implies clearing the sock TX queue. > This might cause unexpected out-of-order transmit, as outstanding packets > can pick a different TX queue and bypass the ones already queued. > This is undesired in general. More

[PATCH net] net: Do not clear the socket TX queue in sock_orphan()

2020-06-21 Thread Tariq Toukan
sock_orphan() call to sk_set_socket() implies clearing the sock TX queue. This might cause unexpected out-of-order transmit, as outstanding packets can pick a different TX queue and bypass the ones already queued. This is undesired in general. More specifically, it breaks the in-order scheduling pr