Re: [PATCH net] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-08 Thread Tariq Toukan
On 11/5/2020 6:00 PM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 15:22:53 +0200 Tariq Toukan wrote: On 11/4/2020 11:25 PM, Jakub Kicinski wrote: On Wed, 4 Nov 2020 12:21:41 +0200 Tariq Toukan wrote: With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be logically done when HW_CSU

Re: [PATCH net] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 15:22:53 +0200 Tariq Toukan wrote: > On 11/4/2020 11:25 PM, Jakub Kicinski wrote: > > On Wed, 4 Nov 2020 12:21:41 +0200 Tariq Toukan wrote: > >> With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be > >> logically done when HW_CSUM offload is off. > > > > Right

Re: [PATCH net] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-05 Thread Tariq Toukan
On 11/4/2020 11:25 PM, Jakub Kicinski wrote: On Wed, 4 Nov 2020 12:21:41 +0200 Tariq Toukan wrote: With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be logically done when HW_CSUM offload is off. Right. Do you expect drivers to nack clearing NETIF_F_HW_TLS_TX when there are a

Re: [PATCH net] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 12:21:41 +0200 Tariq Toukan wrote: > With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be > logically done when HW_CSUM offload is off. Right. Do you expect drivers to nack clearing NETIF_F_HW_TLS_TX when there are active connections, then? I don't think NFP does

[PATCH net] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-04 Thread Tariq Toukan
With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be logically done when HW_CSUM offload is off. Fixes: 2342a8512a1e ("net: Add TLS TX offload features") Signed-off-by: Tariq Toukan Reviewed-by: Boris Pismenny --- net/core/dev.c | 5 + 1 file changed, 5 insertions(+) Hi, Ple