On (02/03/16 09:51), Tom Herbert wrote:
> > (a) quite noisy
>
> Try disabling the crash dump. That will improve performance.
huh??
there is no crash dump involved. If you meant "disable dump_stack()"
sure, I am aware of that, and that is the default behavior of
log_unaligned(). I was just tryi
On Wed, Feb 3, 2016 at 9:31 AM, Sowmini Varadhan
wrote:
> On (02/03/16 09:07), Tom Herbert wrote:
>> > Kernel unaligned access at TPC[9150dc] ipv4_neigh_lookup+0x38/0x170
>>
>> Sowmini,
>>
>> This doesn't look like a hard crash to me. Instead of trying to fix
>> all the alignment issues for Sparc,
On (02/03/16 09:07), Tom Herbert wrote:
> > Kernel unaligned access at TPC[9150dc] ipv4_neigh_lookup+0x38/0x170
>
> Sowmini,
>
> This doesn't look like a hard crash to me. Instead of trying to fix
> all the alignment issues for Sparc, can we just take the trap, fix up
> the load, and continue wit
On Mon, Feb 1, 2016 at 4:31 PM, Sowmini Varadhan
wrote:
> On (01/31/16 13:37), Tom Herbert wrote:
>>
>> Call get_unaligned_be32 when we access 32-bit fields in
>> __skb_flow_dissect. At the beginning check for unlikely case of
>> 1-byte aligned packet.
>>
>> Note that flow_dissector may be asked t
On (02/01/16 19:56), Alexander Duyck wrote:
> > @@ -394,7 +407,7 @@ ip_proto_again:
> >data, hlen, &_eth);
> > if (!eth)
> > goto out_bad;
> > - proto = eth->h_proto;
>
On 02.02.2016 04:56, Alexander Duyck wrote:
@@ -394,7 +407,7 @@ ip_proto_again:
data, hlen, &_eth);
if (!eth)
goto out_bad;
- proto = eth->h_proto;
+
On Mon, Feb 1, 2016 at 4:31 PM, Sowmini Varadhan
wrote:
> On (01/31/16 13:37), Tom Herbert wrote:
>>
>> Call get_unaligned_be32 when we access 32-bit fields in
>> __skb_flow_dissect. At the beginning check for unlikely case of
>> 1-byte aligned packet.
>>
>> Note that flow_dissector may be asked t
On Mon, Feb 1, 2016 at 4:31 PM, Sowmini Varadhan
wrote:
> On (01/31/16 13:37), Tom Herbert wrote:
>>
>> Call get_unaligned_be32 when we access 32-bit fields in
>> __skb_flow_dissect. At the beginning check for unlikely case of
>> 1-byte aligned packet.
>>
>> Note that flow_dissector may be asked t
On (01/31/16 13:37), Tom Herbert wrote:
>
> Call get_unaligned_be32 when we access 32-bit fields in
> __skb_flow_dissect. At the beginning check for unlikely case of
> 1-byte aligned packet.
>
> Note that flow_dissector may be asked to parse packet unaligned
> fields in two instances:
I tested t
On (02/01/16 16:20), Nicolas Dichtel wrote:
> There is also the tile architecture, up to 76 cores on the board I've seen. It
> requires an alignment on 8!
> I wonder how this case may be properly handled. A simple ipip scenario fails.
Yes, I'm also observing the same thing. Simply setting up greta
Le 01/02/2016 01:39, Florian Fainelli a écrit :
Le 31/01/2016 16:24, Eric Dumazet a écrit :
On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
Call get_unaligned_be32 when we access 32-bit fields in
__skb_flow_dissect. At the beginning check for unlikely case of
1-byte aligned packet.
Note
Hello.
On 2/1/2016 12:37 AM, Tom Herbert wrote:
Call get_unaligned_be32 when we access 32-bit fields in
__skb_flow_dissect. At the beginning check for unlikely case of
1-byte aligned packet.
Note that flow_dissector may be asked to parse packet unaligned
fields in two instances:
1) Packet fro
On (01/31/16 16:24), Eric Dumazet wrote:
>
> But this test is absolutely useless, what about testing arches that
> actually care ?
>
Yes, I plan to help test this out tomorrow, Tom suggested setting up
gre-teb between x86 and sparc.
--Sowmini
Le 31/01/2016 16:24, Eric Dumazet a écrit :
> On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
>> Call get_unaligned_be32 when we access 32-bit fields in
>> __skb_flow_dissect. At the beginning check for unlikely case of
>> 1-byte aligned packet.
>>
>> Note that flow_dissector may be asked to
On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
> Call get_unaligned_be32 when we access 32-bit fields in
> __skb_flow_dissect. At the beginning check for unlikely case of
> 1-byte aligned packet.
>
> Note that flow_dissector may be asked to parse packet unaligned
> fields in two instances:
Tom Herbert wrote:
> Call get_unaligned_be32 when we access 32-bit fields in
> __skb_flow_dissect. At the beginning check for unlikely case of
> 1-byte aligned packet.
>
> Note that flow_dissector may be asked to parse packet unaligned
> fields in two instances:
>
> 1) Packet from a driver which
Hi Tom,
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Tom-Herbert/net-Allow-flow-dissector-to-handle-non-4-byte-aligned-headers/20160201-053832
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/
Call get_unaligned_be32 when we access 32-bit fields in
__skb_flow_dissect. At the beginning check for unlikely case of
1-byte aligned packet.
Note that flow_dissector may be asked to parse packet unaligned
fields in two instances:
1) Packet from a driver which is aligned to Ethernet header
(2
18 matches
Mail list logo
