Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-10 Thread Vinay Kumar Yadav
On 11/10/2020 9:58 PM, Jakub Kicinski wrote: On Tue, 10 Nov 2020 10:37:11 +0530 Vinay Kumar Yadav wrote: It is not incompatible. It fits in k.org tls infrastructure (TLS-TOE mode). For the current issue we have proposed a fix. What is the issue with proposed fix, can you elaborate and we will

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-10 Thread Jakub Kicinski
On Tue, 10 Nov 2020 10:37:11 +0530 Vinay Kumar Yadav wrote: > It is not incompatible. It fits in k.org tls infrastructure (TLS-TOE > mode). For the current issue we have proposed a fix. What is the issue > with proposed fix, can you elaborate and we will address that? Your lack of understanding

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-09 Thread Vinay Kumar Yadav
On 11/10/2020 10:37 AM, Vinay Kumar Yadav wrote: On 11/10/2020 12:28 AM, Jakub Kicinski wrote: On Tue, 10 Nov 2020 00:21:13 +0530 Vinay Kumar Yadav wrote: On 11/7/2020 1:58 AM, Jakub Kicinski wrote: On Sat, 7 Nov 2020 02:02:42 +0530 Vinay Kumar Yadav wrote: On 11/6/2020 12:16 AM, Jakub K

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-09 Thread Vinay Kumar Yadav
On 11/10/2020 12:28 AM, Jakub Kicinski wrote: On Tue, 10 Nov 2020 00:21:13 +0530 Vinay Kumar Yadav wrote: On 11/7/2020 1:58 AM, Jakub Kicinski wrote: On Sat, 7 Nov 2020 02:02:42 +0530 Vinay Kumar Yadav wrote: On 11/6/2020 12:16 AM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 23:55:15 +0530 Vi

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-09 Thread Jakub Kicinski
On Tue, 10 Nov 2020 00:21:13 +0530 Vinay Kumar Yadav wrote: > On 11/7/2020 1:58 AM, Jakub Kicinski wrote: > > On Sat, 7 Nov 2020 02:02:42 +0530 Vinay Kumar Yadav wrote: > >> On 11/6/2020 12:16 AM, Jakub Kicinski wrote: > >>> On Thu, 5 Nov 2020 23:55:15 +0530 Vinay Kumar Yadav wrote: > >>>

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-09 Thread Vinay Kumar Yadav
Jakub, On 11/7/2020 1:58 AM, Jakub Kicinski wrote: On Sat, 7 Nov 2020 02:02:42 +0530 Vinay Kumar Yadav wrote: On 11/6/2020 12:16 AM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 23:55:15 +0530 Vinay Kumar Yadav wrote: We should prevent from the socket getting into LISTEN state in the first place.

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-06 Thread Jakub Kicinski
On Sat, 7 Nov 2020 02:02:42 +0530 Vinay Kumar Yadav wrote: > On 11/6/2020 12:16 AM, Jakub Kicinski wrote: > > On Thu, 5 Nov 2020 23:55:15 +0530 Vinay Kumar Yadav wrote: > > We should prevent from the socket getting into LISTEN state in the > > first place. Can we make a copy of proto_ops

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-06 Thread Vinay Kumar Yadav
On 11/6/2020 12:16 AM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 23:55:15 +0530 Vinay Kumar Yadav wrote: We should prevent from the socket getting into LISTEN state in the first place. Can we make a copy of proto_ops (like tls_sw_proto_ops) and set listen to sock_no_listen? Once tls-toe (TLS

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 23:55:15 +0530 Vinay Kumar Yadav wrote: > >>> We should prevent from the socket getting into LISTEN state in the > >>> first place. Can we make a copy of proto_ops (like tls_sw_proto_ops) > >>> and set listen to sock_no_listen? > >> > >> Once tls-toe (TLS_HW_RECORD) is configur

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-05 Thread Vinay Kumar Yadav
On 11/5/2020 11:23 PM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 23:20:13 +0530 Vinay Kumar Yadav wrote: On 11/5/2020 6:46 AM, Jakub Kicinski wrote: On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: user can initialize tls ulp using setsockopt call on socket before listen() in case

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 23:20:13 +0530 Vinay Kumar Yadav wrote: > On 11/5/2020 6:46 AM, Jakub Kicinski wrote: > > On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: > >> user can initialize tls ulp using setsockopt call on socket > >> before listen() in case of tls-toe (TLS_HW_RECORD) and sam

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-05 Thread Vinay Kumar Yadav
On 11/5/2020 6:46 AM, Jakub Kicinski wrote: On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: user can initialize tls ulp using setsockopt call on socket before listen() in case of tls-toe (TLS_HW_RECORD) and same setsockopt call on connected socket in case of kernel tls (TLS_SW). I

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: > user can initialize tls ulp using setsockopt call on socket > before listen() in case of tls-toe (TLS_HW_RECORD) and same > setsockopt call on connected socket in case of kernel tls (TLS_SW). > In presence of tls-toe devices, TLS ulp is

[PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-03 Thread Vinay Kumar Yadav
user can initialize tls ulp using setsockopt call on socket before listen() in case of tls-toe (TLS_HW_RECORD) and same setsockopt call on connected socket in case of kernel tls (TLS_SW). In presence of tls-toe devices, TLS ulp is initialized, tls context is allocated per listen socket and socket i