Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-20 Thread Jakub Kicinski
On Wed, 20 May 2020 15:56:56 -0400 Pooja Trivedi wrote: > On Tue, May 19, 2020 at 5:43 PM Jakub Kicinski wrote: > > > > On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > > > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-20 Thread Pooja Trivedi
On Tue, May 19, 2020 at 5:43 PM Jakub Kicinski wrote: > > On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > > > > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > > > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for > > > encrypted record) gets treated as error, s

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-19 Thread Pooja Trivedi
On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for > > encrypted record) gets treated as error, subtracts the offset, and > > returns to application. Because of

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-18 Thread Jakub Kicinski
On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for > encrypted record) gets treated as error, subtracts the offset, and > returns to application. Because of this, application sends data from > subtracted offset, which lead

[PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-17 Thread Pooja Trivedi
In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for encrypted record) gets treated as error, subtracts the offset, and returns to application. Because of this, application sends data from subtracted offset, which leads to data integrity issue. Since record is already encrypted, kt