Re: [PATCH net] net/sched: pfifo_fast: fix wrong dereference in pfifo_fast_enqueue

2019-08-28 Thread David Miller
From: Davide Caratti Date: Tue, 27 Aug 2019 23:18:53 +0200 > Now that 'TCQ_F_CPUSTATS' bit can be cleared, depending on the value of > 'TCQ_F_NOLOCK' bit in the parent qdisc, we can't assume anymore that > per-cpu counters are there in the error path of skb_array_produce(). > Otherwise, the follo

Re: [PATCH net] net/sched: pfifo_fast: fix wrong dereference in pfifo_fast_enqueue

2019-08-27 Thread Paolo Abeni
On Tue, 2019-08-27 at 23:18 +0200, Davide Caratti wrote: > Now that 'TCQ_F_CPUSTATS' bit can be cleared, depending on the value of > 'TCQ_F_NOLOCK' bit in the parent qdisc, we can't assume anymore that > per-cpu counters are there in the error path of skb_array_produce(). > Otherwise, the following

[PATCH net] net/sched: pfifo_fast: fix wrong dereference in pfifo_fast_enqueue

2019-08-27 Thread Davide Caratti
Now that 'TCQ_F_CPUSTATS' bit can be cleared, depending on the value of 'TCQ_F_NOLOCK' bit in the parent qdisc, we can't assume anymore that per-cpu counters are there in the error path of skb_array_produce(). Otherwise, the following splat can be seen: Unable to handle kernel paging request at v