Re: [PATCH net] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread David Ahern
On 10/9/18 10:12 AM, Davide Caratti wrote: >>> --- a/net/sched/cls_api.c >>> +++ b/net/sched/cls_api.c >>> @@ -37,6 +37,11 @@ static LIST_HEAD(tcf_proto_base); >>> /* Protects list of registered TC modules. It is pure SMP lock. */ >>> static DEFINE_RWLOCK(cls_mod_lock); >>> >>> +const struct nl

Re: [PATCH net] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread Davide Caratti
On Tue, 2018-10-09 at 08:46 -0600, David Ahern wrote: > On 10/9/18 7:10 AM, Davide Caratti wrote: > > Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy > > validation for tc attributes"), add validation for TCA_CHAIN and TCA_KIND > > netlink attributes. > > > > tested with:

Re: [PATCH net] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread David Ahern
On 10/9/18 7:10 AM, Davide Caratti wrote: > Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy > validation for tc attributes"), add validation for TCA_CHAIN and TCA_KIND > netlink attributes. > > tested with: > # ./tdc.py -c filter > > Fixes: 5bc1701881e39 ("net: sched: in

[PATCH net] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread Davide Caratti
Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes"), add validation for TCA_CHAIN and TCA_KIND netlink attributes. tested with: # ./tdc.py -c filter Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters") Signed-off-by: Da