Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-11 Thread Saeed Mahameed
On Mon, 2020-06-08 at 14:22 -0700, Nathan Chancellor wrote: > On Thu, Jun 04, 2020 at 04:44:00AM +, Saeed Mahameed wrote: > > On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote: > > > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor > > > wrote: > > > > On Tue, Jun 02, 2020 a

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-08 Thread Nathan Chancellor
On Thu, Jun 04, 2020 at 04:44:00AM +, Saeed Mahameed wrote: > On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote: > > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote: > > > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-03 Thread Saeed Mahameed
On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote: > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote: > > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Clang warns: > > > > > > drivers/net/ethernet/mellanox/mlx

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-03 Thread Nathan Chancellor
On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote: > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Clang warns: > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > > 'err' is used uninitialized wh

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-02 Thread David Miller
Saeed, please pick this up.

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-02 Thread Nathan Chancellor
On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > 'err' is used uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!priv->

[PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-02 Thread Leon Romanovsky
From: Leon Romanovsky Clang warns: drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!priv->dbg_root) { ^~~ drivers/net/ethernet/mellanox/mlx5/core/m