Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-25 Thread Tariq Toukan
On 25/05/2017 4:07 PM, Tariq Toukan wrote: On 24/05/2017 10:36 PM, David Miller wrote: From: Tariq Toukan Date: Tue, 23 May 2017 15:50:07 +0300 diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c index ae5fdc2df654..00a7cd3dcc2e 1

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-25 Thread Tariq Toukan
On 24/05/2017 10:36 PM, David Miller wrote: From: Tariq Toukan Date: Tue, 23 May 2017 15:50:07 +0300 diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c index ae5fdc2df654..00a7cd3dcc2e 100644 --- a/drivers/net/ethernet/mellanox/mlx4

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-24 Thread David Miller
From: Tariq Toukan Date: Tue, 23 May 2017 15:50:07 +0300 > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > index ae5fdc2df654..00a7cd3dcc2e 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > +++ b/drivers/net/ethern

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-23 Thread Leon Romanovsky
On Tue, May 23, 2017 at 04:15:13PM +0300, Leon Romanovsky wrote: > On Tue, May 23, 2017 at 03:50:07PM +0300, Tariq Toukan wrote: > > From: Talat Batheesh > > > > Our previous patch (cited below) introduced a regression > > for RAW Eth QPs. > > > > Fix it by checking if the QP number provided by us

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-23 Thread Or Gerlitz
On 5/23/2017 3:50 PM, Tariq Toukan wrote: From: Talat Batheesh Our previous patch (cited below) introduced a regression for RAW Eth QPs. Fix it by checking if the QP number provided by user-space exists, hence allowing steering rules to be added for valid QPs only. Fixes: 89c557687a32 ("net/m

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-23 Thread Leon Romanovsky
On Tue, May 23, 2017 at 03:50:07PM +0300, Tariq Toukan wrote: > From: Talat Batheesh > > Our previous patch (cited below) introduced a regression > for RAW Eth QPs. > > Fix it by checking if the QP number provided by user-space > exists, hence allowing steering rules to be added for valid > QPs on

[PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-23 Thread Tariq Toukan
From: Talat Batheesh Our previous patch (cited below) introduced a regression for RAW Eth QPs. Fix it by checking if the QP number provided by user-space exists, hence allowing steering rules to be added for valid QPs only. Fixes: 89c557687a32 ("net/mlx4_en: Avoid adding steering rules with ...