Re: [PATCH net] net/ipv4: Initialize proto and ports in flow struct

2018-05-16 Thread David Ahern
On 5/16/18 12:18 PM, David Ahern wrote: > @@ -347,8 +348,11 @@ static int __fib_validate_source(struct sk_buff *skb, > __be32 src, __be32 dst, > no_addr = idev->ifa_list == NULL; > > fl4.flowi4_mark = IN_DEV_SRC_VMARK(idev) ? skb->mark : 0; > - > - trace_fib_validate_source(dev,

[PATCH net] net/ipv4: Initialize proto and ports in flow struct

2018-05-16 Thread David Ahern
Updating the FIB tracepoint for the recent change to allow rules using the protocol and ports exposed a few places where the entries in the flow struct are not initialized. For __fib_validate_source add the call to fib4_rules_early_flow_dissect since it is invoked for the input path. For netfilter