Re: [PATCH net] mptcp: sendmsg: reset iter on error redux

2020-08-17 Thread Jakub Kicinski
On Sun, 16 Aug 2020 23:14:20 +0200 Florian Westphal wrote: > This fix wasn't correct: When this function is invoked from the > retransmission worker, the iterator contains garbage and resetting > it causes a crash. > > As the work queue should not be performance critical also zero the > msghdr str

Re: [PATCH net] mptcp: sendmsg: reset iter on error redux

2020-08-16 Thread David Miller
From: Florian Westphal Date: Sun, 16 Aug 2020 23:14:20 +0200 > This fix wasn't correct: When this function is invoked from the > retransmission worker, the iterator contains garbage and resetting > it causes a crash. > > As the work queue should not be performance critical also zero the > msghdr

[PATCH net] mptcp: sendmsg: reset iter on error redux

2020-08-16 Thread Florian Westphal
This fix wasn't correct: When this function is invoked from the retransmission worker, the iterator contains garbage and resetting it causes a crash. As the work queue should not be performance critical also zero the msghdr struct. Fixes: 35759383133f64d "(mptcp: sendmsg: reset iter on error)" Si

Re: [PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread David Miller
From: Florian Westphal Date: Fri, 14 Aug 2020 15:56:34 +0200 > Once we've copied data from the iterator we need to revert in case we > end up not sending any data. > > This bug doesn't trigger with normal 'poll' based tests, because > we only feed a small chunk of data to kernel after poll indic

Re: [PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread Mat Martineau
On Fri, 14 Aug 2020, Florian Westphal wrote: Once we've copied data from the iterator we need to revert in case we end up not sending any data. This bug doesn't trigger with normal 'poll' based tests, because we only feed a small chunk of data to kernel after poll indicated POLLOUT. With block

[PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread Florian Westphal
Once we've copied data from the iterator we need to revert in case we end up not sending any data. This bug doesn't trigger with normal 'poll' based tests, because we only feed a small chunk of data to kernel after poll indicated POLLOUT. With blocking IO and large writes this triggers. Receiver