Re: [PATCH net] mptcp: replace mptcp_disconnect with a stub

2020-04-29 Thread David Miller
From: Florian Westphal Date: Wed, 29 Apr 2020 20:43:20 +0200 > Paolo points out that mptcp_disconnect is bogus: > "lock_sock(sk); > looks suspicious (lock should be already held by the caller) > And call to: tcp_disconnect(sk, flags); too, sk is not a tcp > socket". > > ->disconnect() gets calle

[PATCH net] mptcp: replace mptcp_disconnect with a stub

2020-04-29 Thread Florian Westphal
Paolo points out that mptcp_disconnect is bogus: "lock_sock(sk); looks suspicious (lock should be already held by the caller) And call to: tcp_disconnect(sk, flags); too, sk is not a tcp socket". ->disconnect() gets called from e.g. inet_stream_connect when one tries to disassociate a connected so