Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/30/2018 2:30 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 5:08 PM Qing Huang wrote: On 5/30/2018 1:50 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 5:08 PM Qing Huang wrote: > > > > On 5/30/2018 1:50 PM, Eric Dumazet wrote: > > On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: > >> > >> > >> On 5/29/2018 9:11 PM, Eric Dumazet wrote: > >>> Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") > >>>

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/30/2018 1:50 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. If KASAN

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: > > > > On 5/29/2018 9:11 PM, Eric Dumazet wrote: > > Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") > > brought a regression caught in our regression suite, thanks to KASAN. > > If KASAN reported issue was really caused

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. If KASAN reported issue was really caused by smaller chunk sizes, changing allocation order dynamically

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Tariq Toukan
On 30/05/2018 7:11 AM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. Note that mlx4_alloc_icm() is already able to try high order allocations and fallback to low-order alloca

[PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-29 Thread Eric Dumazet
Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. Note that mlx4_alloc_icm() is already able to try high order allocations and fallback to low-order allocations under high memory pressure. We only have