Re: [PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread David Lebrun
On 05/15/2017 12:53 PM, David Lebrun wrote: > I can fix the issue with a simpler ifdef. The simpler ifdef works fine, but a patch to iproute2 is still needed. David signature.asc Description: OpenPGP digital signature

Re: [PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread David Lebrun
On 05/15/2017 12:43 PM, Daniel Borkmann wrote: > > Okay, thanks! Mmmh actually I can fix this without sending a patch to iproute2. Handling the __USE_KERNEL_IPV6_DEFS case in seg6.h is wrong, as it is already performed in netinet/in.h. I can fix the issue with a simpler ifdef. Will send v2. Dav

Re: [PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread Daniel Borkmann
On 05/15/2017 12:37 PM, David Lebrun wrote: On 05/15/2017 12:05 PM, Daniel Borkmann wrote: Or, is there still another fix for iproute2 coming after this has landed? Yes, I will submit the fix to iproute2 once this one has been applied, so that I can reference it. Okay, thanks!

Re: [PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread David Lebrun
On 05/15/2017 12:05 PM, Daniel Borkmann wrote: > > Or, is there still another fix for iproute2 coming after this has > landed? Yes, I will submit the fix to iproute2 once this one has been applied, so that I can reference it. David signature.asc Description: OpenPGP digital signature

Re: [PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread Daniel Borkmann
On 05/15/2017 11:18 AM, David Lebrun wrote: When seg6.h is included in a user space program that also includes netinet/in.h, it results in multiple definitions of structures such as struct in6_addr. Recent glibc versions have a workaround that consists in defining __USE_KERNEL_IPV6_DEFS to preven

[PATCH net] ipv6: sr: fix user space compilation error with old glibc

2017-05-15 Thread David Lebrun
When seg6.h is included in a user space program that also includes netinet/in.h, it results in multiple definitions of structures such as struct in6_addr. Recent glibc versions have a workaround that consists in defining __USE_KERNEL_IPV6_DEFS to prevent duplicates. However, such a program will fai