Re: [PATCH net] ipv6: fix suspecious RCU usage warning

2021-03-09 Thread David Ahern
On 3/9/21 10:32 AM, Wei Wang wrote: > Thanks David and Ido. > To clarify, David, you suggest we add a separate function instead of > adding an extra parameter, right? for this case I think it is the better way to go.

Re: [PATCH net] ipv6: fix suspecious RCU usage warning

2021-03-09 Thread Ido Schimmel
On Mon, Mar 08, 2021 at 07:47:31PM -0700, David Ahern wrote: > [ cc Ido and Petr ] > > On 3/8/21 12:21 PM, Wei Wang wrote: > > diff --git a/include/net/nexthop.h b/include/net/nexthop.h > > index 7bc057aee40b..48956b144689 100644 > > --- a/include/net/nexthop.h > > +++ b/include/net/nexthop.h > >

Re: [PATCH net] ipv6: fix suspecious RCU usage warning

2021-03-08 Thread David Ahern
[ cc Ido and Petr ] On 3/8/21 12:21 PM, Wei Wang wrote: > diff --git a/include/net/nexthop.h b/include/net/nexthop.h > index 7bc057aee40b..48956b144689 100644 > --- a/include/net/nexthop.h > +++ b/include/net/nexthop.h > @@ -410,31 +410,39 @@ static inline struct fib_nh *fib_info_nh(struct > fib_