Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread kbuild test robot
Hi Sabrina, [auto build test ERROR on net/master] [also ERROR on: v4.3 next-20151103] url: https://github.com/0day-ci/linux/commits/Sabrina-Dubroca/ipv6-clean-up-dev_snmp6-proc-entry-when-we-fail-to-initialize-inet6_dev/20151104-021328 base: https://github.com/0day-ci/linux Sabrina-Dubroca

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread kbuild test robot
Hi Sabrina, [auto build test ERROR on net/master] [also ERROR on: v4.3 next-20151103] url: https://github.com/0day-ci/linux/commits/Sabrina-Dubroca/ipv6-clean-up-dev_snmp6-proc-entry-when-we-fail-to-initialize-inet6_dev/20151104-021328 base: https://github.com/0day-ci/linux Sabrina-Dubroca

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread Sabrina Dubroca
2015-11-03, 13:38:37 -0500, David Miller wrote: > From: Cong Wang > Date: Tue, 3 Nov 2015 10:30:20 -0800 > > > On Tue, Nov 3, 2015 at 10:09 AM, Sabrina Dubroca > > wrote: > >> In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > >> the dev_snmp6 entry that we have already

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread David Miller
From: Cong Wang Date: Tue, 3 Nov 2015 10:30:20 -0800 > On Tue, Nov 3, 2015 at 10:09 AM, Sabrina Dubroca wrote: >> In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up >> the dev_snmp6 entry that we have already registered for this device. >> >> It is safe to call snmp6_unregi

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread David Miller
From: Sabrina Dubroca Date: Tue, 3 Nov 2015 19:09:09 +0100 > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > > It is safe to call snmp6_unregister_dev unconditionally from > in6_dev_finish_destroy,

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread Cong Wang
On Tue, Nov 3, 2015 at 10:09 AM, Sabrina Dubroca wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > > It is safe to call snmp6_unregister_dev unconditionally from > in6_dev_finish_destroy, so do

Re: [PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread Dmitry Vyukov
On Tue, Nov 3, 2015 at 7:09 PM, Sabrina Dubroca wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > > It is safe to call snmp6_unregister_dev unconditionally from > in6_dev_finish_destroy, so do

[PATCH net] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-03 Thread Sabrina Dubroca
In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up the dev_snmp6 entry that we have already registered for this device. It is safe to call snmp6_unregister_dev unconditionally from in6_dev_finish_destroy, so do it. Reported-by: Dmitry Vyukov Acked-by: Hannes Frederic Sowa