Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Eric Dumazet
On Thu, 2016-10-20 at 14:00 -0700, Cong Wang wrote: > Error prone vs. space saving, it's up to you... > > But clearly current code is still broken even after your patch. I will send > a revert + previous typo fix. Yes please do.

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Cong Wang
On Thu, Oct 20, 2016 at 1:43 PM, Eric Dumazet wrote: > On Thu, 2016-10-20 at 12:44 -0700, Cong Wang wrote: >> On Thu, Oct 20, 2016 at 12:40 PM, Cong Wang wrote: >> > On Thu, Oct 20, 2016 at 12:32 PM, Cong Wang >> > wrote: >> >> On Thu, Oct 20, 2016 at 10:26 AM, Eric Dumazet >> >> wrote: >> >>

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Eric Dumazet
On Thu, 2016-10-20 at 12:44 -0700, Cong Wang wrote: > On Thu, Oct 20, 2016 at 12:40 PM, Cong Wang wrote: > > On Thu, Oct 20, 2016 at 12:32 PM, Cong Wang > > wrote: > >> On Thu, Oct 20, 2016 at 10:26 AM, Eric Dumazet > >> wrote: > >>> From: Eric Dumazet > >>> > >>> In commit 4ee3bd4a8c746 ("ip

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Cong Wang
On Thu, Oct 20, 2016 at 12:40 PM, Cong Wang wrote: > On Thu, Oct 20, 2016 at 12:32 PM, Cong Wang wrote: >> On Thu, Oct 20, 2016 at 10:26 AM, Eric Dumazet >> wrote: >>> From: Eric Dumazet >>> >>> In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port >>> range") Cong added BH pr

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Cong Wang
On Thu, Oct 20, 2016 at 12:32 PM, Cong Wang wrote: > On Thu, Oct 20, 2016 at 10:26 AM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port >> range") Cong added BH protection in set_local_port_range() but missed >> that same fix

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Cong Wang
On Thu, Oct 20, 2016 at 10:26 AM, Eric Dumazet wrote: > From: Eric Dumazet > > In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port > range") Cong added BH protection in set_local_port_range() but missed > that same fix was needed in set_ping_group_range() Don't know why ping_g

Re: [PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread David Miller
From: Eric Dumazet Date: Thu, 20 Oct 2016 10:26:48 -0700 > From: Eric Dumazet > > In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port > range") Cong added BH protection in set_local_port_range() but missed > that same fix was needed in set_ping_group_range() > > Fixes: b8f1a

[PATCH net] ipv4: disable BH in set_ping_group_range()

2016-10-20 Thread Eric Dumazet
From: Eric Dumazet In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port range") Cong added BH protection in set_local_port_range() but missed that same fix was needed in set_ping_group_range() Fixes: b8f1a55639e6 ("udp: Add function to make source port for UDP tunnels") Signed-