Re: [PATCH net] ipv4: Update exception handling for multipath routes via same device

2020-10-07 Thread Tobias Brunner
Hi David, > @@ -2668,8 +2673,6 @@ struct rtable *ip_route_output_key_hash_rcu(struct net > *net, struct flowi4 *fl4, > fib_select_path(net, res, fl4, skb); > > dev_out = FIB_RES_DEV(*res); > - fl4->flowi4_oif = dev_out->ifindex; > - > > make_route: > rth = __mkroute_out

Re: [PATCH net] ipv4: Update exception handling for multipath routes via same device

2020-09-15 Thread David Ahern
On 9/15/20 4:46 PM, David Miller wrote: > > The example topology and commands look like a good addition for > selftests perhaps? > Definitely. I plan to integrate it into pmtu.sh.

Re: [PATCH net] ipv4: Update exception handling for multipath routes via same device

2020-09-15 Thread David Miller
From: David Ahern Date: Mon, 14 Sep 2020 21:03:54 -0600 > Kfir reported that pmtu exceptions are not created properly for > deployments where multipath routes use the same device. > > After some digging I see 2 compounding problems: > 1. ip_route_output_key_hash_rcu is updating the flowi4_oif *a

[PATCH net] ipv4: Update exception handling for multipath routes via same device

2020-09-14 Thread David Ahern
Kfir reported that pmtu exceptions are not created properly for deployments where multipath routes use the same device. After some digging I see 2 compounding problems: 1. ip_route_output_key_hash_rcu is updating the flowi4_oif *after* the route lookup. This is the second use case where this ha