Re: [PATCH net] ip: on queued skb use skb_header_pointer instead of pskb_may_pull

2019-01-10 Thread David Miller
From: Willem de Bruijn Date: Mon, 7 Jan 2019 16:47:33 -0500 > From: Willem de Bruijn > > Commit 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call > pskb_may_pull") avoided a read beyond the end of the skb linear > segment by calling pskb_may_pull. > > That function can trigger a BUG_ON in ps

[PATCH net] ip: on queued skb use skb_header_pointer instead of pskb_may_pull

2019-01-07 Thread Willem de Bruijn
From: Willem de Bruijn Commit 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") avoided a read beyond the end of the skb linear segment by calling pskb_may_pull. That function can trigger a BUG_ON in pskb_expand_head if the skb is shared, which it is when when peeking. It can al