Re: [PATCH net] gro_cell: add napi_disable in gro_cells_destroy

2019-01-14 Thread Eric Dumazet
On 12/19/2018 02:46 PM, Eric Dumazet wrote: > On Wed, Dec 19, 2018 at 2:23 PM Lorenzo Bianconi > wrote: >> >> Add napi_disable routine in gro_cells_destroy since starting from >> commit c42858eaf492 ("gro_cells: remove spinlock protecting receive >> queues") gro_cell_poll and gro_cells_destroy

Re: [PATCH net] gro_cell: add napi_disable in gro_cells_destroy

2018-12-19 Thread David Miller
From: Lorenzo Bianconi Date: Wed, 19 Dec 2018 23:23:00 +0100 > Add napi_disable routine in gro_cells_destroy since starting from > commit c42858eaf492 ("gro_cells: remove spinlock protecting receive > queues") gro_cell_poll and gro_cells_destroy can run concurrently on > napi_skbs list producing

Re: [PATCH net] gro_cell: add napi_disable in gro_cells_destroy

2018-12-19 Thread Eric Dumazet
On Wed, Dec 19, 2018 at 2:23 PM Lorenzo Bianconi wrote: > > Add napi_disable routine in gro_cells_destroy since starting from > commit c42858eaf492 ("gro_cells: remove spinlock protecting receive > queues") gro_cell_poll and gro_cells_destroy can run concurrently on > napi_skbs list producing a ke

[PATCH net] gro_cell: add napi_disable in gro_cells_destroy

2018-12-19 Thread Lorenzo Bianconi
Add napi_disable routine in gro_cells_destroy since starting from commit c42858eaf492 ("gro_cells: remove spinlock protecting receive queues") gro_cell_poll and gro_cells_destroy can run concurrently on napi_skbs list producing a kernel Oops if the tunnel interface is removed while gro_cell_poll is