Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 6:31 PM, Thomas Graf wrote: > On 01/20/16 at 05:47pm, Jesse Gross wrote: >> Just to merge the two threads together, all of protocols that would be >> affected by this also have "normal" GRO handlers that will run when >> the packet is first received. There's no argument tha

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Thomas Graf
On 01/20/16 at 05:47pm, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available. However, GRO ce

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:47 -0800, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available. How

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: >> GRO is currently not aware of tunnel metadata generated by lightweight >> tunnels and stored in the dst. This leads to two possible problems: >> * Incorrectly merging two frames that ha

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata f

[PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
GRO is currently not aware of tunnel metadata generated by lightweight tunnels and stored in the dst. This leads to two possible problems: * Incorrectly merging two frames that have different metadata. * Leaking of allocated metadata from merged frames. This avoids those problems by comparing th