Re: [PATCH net] geneve: pull IP header before ECN decapsulation

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 01:05:07 -0800 Eric Dumazet wrote: > From: Eric Dumazet > > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume > IP header is already pulled. > > geneve does not ensure this yet. > > Fixing this generically in IP_ECN_decapsulate() and > IP6_ECN_decapsulate() is not possib

[PATCH net] geneve: pull IP header before ECN decapsulation

2020-12-01 Thread Eric Dumazet
From: Eric Dumazet IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume IP header is already pulled. geneve does not ensure this yet. Fixing this generically in IP_ECN_decapsulate() and IP6_ECN_decapsulate() is not possible, since callers pass a pointer that might be freed by pskb_may_pull()