Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Mar 2021 20:08:57 + you wrote: > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > ICMP header has its ID field in network byteorder obviously. > Sparse says: > > net/core/flow_dissector.c:178:43: war

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread David Miller
From: Vladimir Oltean Date: Sun, 14 Mar 2021 20:44:49 + > On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote: >> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: >> >> Smells like a breaking change for existing consumers of this value. >> >> How about we change the

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread Vladimir Oltean
On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote: > On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: > > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > > ICMP header has its ID field in network byteorder obviously. > > Sparse says: > > > > net/core/flow_di

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread Jakub Sitnicki
On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > ICMP header has its ID field in network byteorder obviously. > Sparse says: > > net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to > integer > > Conv

[PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-12 Thread Alexander Lobakin
flow_dissector_key_icmp::id is of type u16 (CPU byteorder), ICMP header has its ID field in network byteorder obviously. Sparse says: net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to integer Convert ID value to CPU byteorder when storing it into flow_dissector_key_icmp. F