irussk...@marvell.com;
> gust...@embeddedor.com; magnus.karls...@intel.com;
> ec...@solarflare.com; Ido Schimmel ; Jiri Pirko
> ; mlxsw
> Subject: Re: [PATCH net] ethtool: Add indicator field for link_mode validity
> to link_ksettings
>
> On Thu, 4 Mar 2021 11:09:33 +02
On Thu, Mar 4, 2021 at 2:08 PM Edwin Peer wrote:
> On Thu, Mar 4, 2021 at 1:13 AM Danielle Ratson wrote:
>
> > --- a/include/linux/ethtool.h
> > +++ b/include/linux/ethtool.h
> > @@ -130,6 +130,7 @@ struct ethtool_link_ksettings {
> > } link_modes;
> > u32 lanes;
> >
On Thu, Mar 4, 2021 at 1:13 AM Danielle Ratson wrote:
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -130,6 +130,7 @@ struct ethtool_link_ksettings {
> } link_modes;
> u32 lanes;
> enum ethtool_link_mode_bit_indices link_mode;
> + bool link_
On Thu, 4 Mar 2021 11:09:33 +0200 Danielle Ratson wrote:
> Some drivers clear the 'ethtool_link_ksettings' struct in their
> get_link_ksettings() callback, before populating it with actual values.
> Such drivers will set the new 'link_mode' field to zero, resulting in
> user space receiving wrong l
Some drivers clear the 'ethtool_link_ksettings' struct in their
get_link_ksettings() callback, before populating it with actual values.
Such drivers will set the new 'link_mode' field to zero, resulting in
user space receiving wrong link mode information given that zero is a
valid value for the fie
