RE: [PATCH net] enetc: Avoid implicit sign extension

2021-03-29 Thread Claudiu Manoil
>-Original Message- >From: Claudiu Manoil >Sent: Monday, March 29, 2021 4:35 PM >To: netdev@vger.kernel.org >Cc: Jakub Kicinski ; David S . Miller >; Vladimir Oltean >Subject: [PATCH net] enetc: Avoid implicit sign extension > >Static analysis tool reports:

[PATCH net] enetc: Avoid implicit sign extension

2021-03-29 Thread Claudiu Manoil
Static analysis tool reports: "Suspicious implicit sign extension - 'flags' with type u8 (8 bit, unsigned) is promoted in 'flags' << 24 to type int (32 bits, signed), then sign-extended to type unsigned long long (64 bits, unsigned). If flags << 24 is greater than 0x7FFF, the upper bits of the