Re:Re: [PATCH net] driver: vrf: Fix one possible use-after-free issue

2017-05-09 Thread Gao Feng
At 2017-05-09 17:21:02, "Florian Westphal" wrote: >gfree.w...@vip.163.com wrote: >> When one netfilter rule or hook stoles the skb and return NF_STOLEN, >> it means the skb is taken by the rule, and other modules should not >> touch this skb ever. Maybe the skb is queued or freed directly by the

Re: [PATCH net] driver: vrf: Fix one possible use-after-free issue

2017-05-09 Thread Florian Westphal
gfree.w...@vip.163.com wrote: > When one netfilter rule or hook stoles the skb and return NF_STOLEN, > it means the skb is taken by the rule, and other modules should not > touch this skb ever. Maybe the skb is queued or freed directly by the > rule. > > Now uses the nf_hook instead of NF_HOOK to

[PATCH net] driver: vrf: Fix one possible use-after-free issue

2017-05-09 Thread gfree . wind
From: Gao Feng The current codes only deal with the case that the skb is dropped, it may meet one use-after-free issue when NF_HOOK returns 0 that means the skb is stolen by one netfilter rule or hook. When one netfilter rule or hook stoles the skb and return NF_STOLEN, it means the skb is taken