Re: [PATCH net] dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state

2018-01-26 Thread Alexey Kodanev
On 01/25/2018 09:03 PM, Eric Dumazet wrote: > On Thu, 2018-01-25 at 20:43 +0300, Alexey Kodanev wrote: >> ccid2_hc_tx_rto_expire() timer callback always restarts the timer >> again and can run indefinitely (unless it is stopped outside), and >> after commit 120e9dabaf55 ("dccp: defer ccid_hc_tx_del

Re: [PATCH net] dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state

2018-01-25 Thread Eric Dumazet
On Thu, 2018-01-25 at 20:43 +0300, Alexey Kodanev wrote: > ccid2_hc_tx_rto_expire() timer callback always restarts the timer > again and can run indefinitely (unless it is stopped outside), and > after commit 120e9dabaf55 ("dccp: defer ccid_hc_tx_delete() at > dismantle time"), which moved sk_stop_

[PATCH net] dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state

2018-01-25 Thread Alexey Kodanev
ccid2_hc_tx_rto_expire() timer callback always restarts the timer again and can run indefinitely (unless it is stopped outside), and after commit 120e9dabaf55 ("dccp: defer ccid_hc_tx_delete() at dismantle time"), which moved sk_stop_timer() to sk_destruct(), this started to happen quite often. The