Re: [PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 17:38:09 +0100 Jan Kasprzak wrote: > Wang Hai wrote: > : If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a > : corresponding kfree() in exception handling. Thus add kfree() for this > : function implementation. > > Acked-By: Jan "Yenya" Kasprzak Applied, th

Re: [PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-10 Thread Jan Kasprzak
Wang Hai wrote: : If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a : corresponding kfree() in exception handling. Thus add kfree() for this : function implementation. Acked-By: Jan "Yenya" Kasprzak Looks correct, thanks. That said, COSA is an ancient ISA bus device designed

[PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-10 Thread Wang Hai
If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wan/cosa.c | 1 + 1 file