Re: [PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-28 Thread David Miller
From: Daniel Borkmann Date: Mon, 27 Nov 2017 22:09:33 +0100 > On 11/27/2017 08:11 PM, Jakub Kicinski wrote: >> When cls_bpf offload was added it seemed like a good idea to >> call cls_bpf_delete_prog() instead of extending the error >> handling path, since the software state is fully initialized

Re: [PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-28 Thread Cong Wang
On Mon, Nov 27, 2017 at 11:11 AM, Jakub Kicinski wrote: > When cls_bpf offload was added it seemed like a good idea to > call cls_bpf_delete_prog() instead of extending the error > handling path, since the software state is fully initialized > at that point. This handling of errors without jumpin

Re: [PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-27 Thread Daniel Borkmann
On 11/27/2017 08:11 PM, Jakub Kicinski wrote: > When cls_bpf offload was added it seemed like a good idea to > call cls_bpf_delete_prog() instead of extending the error > handling path, since the software state is fully initialized > at that point. This handling of errors without jumping to > the

[PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-27 Thread Jakub Kicinski
When cls_bpf offload was added it seemed like a good idea to call cls_bpf_delete_prog() instead of extending the error handling path, since the software state is fully initialized at that point. This handling of errors without jumping to the end of the function is error prone, as proven by later c