Re: [PATCH net] chelsio/chtls: fix memory leak

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 23:09:10 +0530 Vinay Kumar Yadav wrote: > Correct skb refcount in alloc_ctrl_skb(), causing skb memleak > when chtls_send_abort() called with NULL skb. > it was always leaking the skb, correct it by incrementing skb > refs by one. > > Fixes: cc35c88ae4db ("crypto : chtls - CPL

[PATCH net] chelsio/chtls: fix memory leak

2020-11-02 Thread Vinay Kumar Yadav
Correct skb refcount in alloc_ctrl_skb(), causing skb memleak when chtls_send_abort() called with NULL skb. it was always leaking the skb, correct it by incrementing skb refs by one. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav --- drivers/net/

Re: [PATCH net] chelsio/chtls: fix memory leak

2020-10-22 Thread kernel test robot
Hi Vinay, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Vinay-Kumar-Yadav/chelsio-chtls-fix-memory-leak/20201023-031509 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 287d35405989

[PATCH net] chelsio/chtls: fix memory leak

2020-10-22 Thread Vinay Kumar Yadav
Correct skb refcount in alloc_ctrl_skb(), causing skb memleak when chtls_send_abort() called with NULL skb. Also race between user context and softirq causing memleak, consider the call sequence scenario chtls_setkey() //user context chtls_peer_close() chtls_abort_req_rss() chtls_setkey()