On 10/26/20 2:28 PM, Stéphane Grosjean wrote:
> Hello Dan,
>
> You have my Ack.
>
> Acked-by: Stephane Grosjean
Applied to linux-can/testing.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertr
; David S. Miller
; Jakub Kicinski ; Andri Yngvason
; Oliver Hartkopp ;
linux-...@vger.kernel.org ; netdev@vger.kernel.org
; kernel-janit...@vger.kernel.org
Objet : [PATCH net] can: peak_usb: add range checking in decode operations
These values come from skb->data so Smatch considers t
On 10/16/20 9:43 AM, Stéphane Grosjean wrote:
> Thank you for your detailed answer. And so? AFAIK I saw that this patch is
> still
> not in mainline. What needs to be done for it to be there? Should I bring an
> Ack, for example?
If you have reviewed the patch, give an Ack or Reviewed-by.
regard
16:06
À : Wolfgang Grandegger ; Stéphane Grosjean
Cc : Marc Kleine-Budde ; David S. Miller ; Jakub Kicinski
; Andri Yngvason ; Oliver Hartkopp ;
linux-...@vger.kernel.org ; netdev@vger.kernel.org ;
kernel-janit...@vger.kernel.org
Objet : [PATCH net] can: peak_usb: add range checking in decode
rg
; kernel-janit...@vger.kernel.org
Objet : [PATCH net] can: peak_usb: add range checking in decode operations
These values come from skb->data so Smatch considers them untrusted. I
believe Smatch is correct but I don't have a way to test this.
The usb_if->dev[] array has 2 elements
These values come from skb->data so Smatch considers them untrusted. I
believe Smatch is correct but I don't have a way to test this.
The usb_if->dev[] array has 2 elements but the index is in the 0-15
range without checks. The cfd->len can be up to 255 but the maximum
valid size is CANFD_MAX_DL
